linux-kernel - Re: [RFC PATCH 3/4] tracing: Kill tracing_open/release_generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Jul 2013 21:19:17 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	"zhangwei(Jovi)" <jovi.zhangwei@...wei.com>,
	Jiri Olsa <jolsa@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 3/4] tracing: Kill tracing_open/release_generic_file

On 07/16, Steven Rostedt wrote:
>
> On Tue, 2013-07-16 at 20:57 +0200, Oleg Nesterov wrote:
> > trace_array_get() goes away. NOTE! this is actually wrong until we
> > change instance_delete() path to nullify ->i_private.
>
> I think this needs to be done first.

Do you mean "change instance_delete() path to nullify ->i_private" ?

Yes. Well yes and no, afaics, but please ignore. Of course, I won't
send the patches with the holes which I knew about.

Once again, this is just RFC to know your and Masami's opinion. If
you think this can work, I'll try to resend this series with the
additional bits to cover instance_delete() too. _Afaics_ this needs
some temporary uglifications "in between".

So far I am sending 5/4 and 6/4 which changes ftrace_event_format_fops,
in reply to 0/4. The only problem with this file is that f_start/next
imho asks for cleanup which comes as 5/4.

Ignoring instance_delete(), I think this is all we need to make
event/* safe.

So please tell me what do you think.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/