linux-kernel - Re: [PATCH V7 01/14] perf tools: add debug prints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Jul 2013 17:10:00 -0300
From:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To:	Adrian Hunter <adrian.hunter@...el.com>
Cc:	linux-kernel@...r.kernel.org, David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jiri Olsa <jolsa@...hat.com>, Mike Galbraith <efault@....de>,
	Namhyung Kim <namhyung@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH V7 01/14] perf tools: add debug prints

Em Wed, Jul 17, 2013 at 03:43:01PM +0300, Adrian Hunter escreveu:
> It is useful to see the arguments to perf_event_open
> and whether the perf events ring buffer was mmapped
> per-cpu or per-thread.  That information will now be
> displayed when verbose is 2 i.e option -vv
> 
> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>
> Acked-by: Jiri Olsa <jolsa@...hat.com>

Please use 'perf test' before sending patchkits:

[root@zoo ~]# perf test
<SNIP>
14: Test matching and linking multiple hists               : Ok
15: Try 'use perf' in python, checking link problems       : FAILED!
16: Test breakpoint overflow signal handler                : FAILED!
17: Test breakpoint overflow sampling                      : FAILED!
18: Test number of exit event of a simple workload         : Ok
19: Test software clock events have valid period values    : Ok
[root@zoo ~]# 
[root@zoo ~]# perf test 15
15: Try 'use perf' in python, checking link problems       : FAILED!
[root@zoo ~]# set -o vi
[root@zoo ~]# perf test -v 15
15: Try 'use perf' in python, checking link problems       :
--- start ---
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: /tmp/build/perf/python/perf.so: undefined symbol: verbose
---- end ----
Try 'use perf' in python, checking link problems: FAILED!
[root@zoo ~]# 


	The python binding only links a subset of the tools/perf/util/ objects
and is an exercise in trying to modularize the functions so that we don't
drag the whole world into it or in any other libraries we come up with.

	Perhaps in this case we need to make the 'verbose' variable
available in one of the object files already in the link kit for the
python binding or plain pass verbose as a parameter to this function. I
tend to prefer the later, to avoid having a tools/utils wide global.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/