Message-ID: <20130717053820.GA1965@skorgonTP.att.net>
Date:	Tue, 16 Jul 2013 22:38:20 -0700
From:	Sören Brinkmann <soeren.brinkmann@...il.com>
To:	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>
Cc:	Willy Tarreau <w@....eu>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	stable@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [REGRESSION 3.10.1] System does not wake up from suspend

On Wed, Jul 17, 2013 at 10:27:15AM +0530, Srivatsa S. Bhat wrote:
> On 07/17/2013 08:27 AM, Sören Brinkmann wrote:
> > On Mon, Jul 15, 2013 at 12:20:19PM +0530, Srivatsa S. Bhat wrote:
> >> On 07/15/2013 10:24 AM, Willy Tarreau wrote:
> >>> On Sun, Jul 14, 2013 at 09:36:25PM -0700, Sören Brinkmann wrote:
> >>>> Hi Greg,
> >>>>
> >>>> since upgrading to 3.10.1 I find my system not waking up from suspend
> >>>> from time to time. Unfortunately, I couldn't figure out how to reliably
> >>>> reproduce the issue. Sometimes it works just fine.
> >>>>
> >>>> All I know so far:
> >>>> On 3.10 I had my system completely freezing a few times. But that did
> >>>> not seem to be related to suspend/resume. I never experienced the
> >>>> behavior described below on 3.10.
> >>>>
> >>>> On 3.10.1 I hit this bug a few times, that my system did not wake up.
> >>>> I.e. the screen stayed black and the power LED kept flashing. But
> >>>> nothing brought the system back up and I had to longpress power to reset
> >>>> the system.
> >>>> I had none of the system freezes like the ones described above anymore.
> >>>
> >>> Fortunately, 3.10.1 is very small. The only patch it contains which is
> >>> related to suspend is 18/19 (cpufreq ondemand governor). Maybe you're
> >>> having a problem with cpufreq on this machine in fact.
> >>>
> >>> You may want to try to force it to performance mode or powersave mode
> >>> and try for a while, it is possible that both 3.10 and 3.10.1 will work
> >>> fine.
> >>>
> >>
> >> Or, you could try applying the patch shown below on top of 3.10.1 and
> >> see if it fixes the suspend/resume regression for you.
> >>
> >> https://lkml.org/lkml/2013/7/11/661
> >>
> >> (Just apply patch 1, not the entire patchset).
> > So, this didn't end well. With that patch applied I end up in a kernel
> > panic on suspend, reproducible - well two out of two is a small test set,
> > but anyway. Unfortunately too late to get any information about it
> > and my logs don't show anything either. But it's seems worse than the
> > rather occasional hangs on resume on the vanilla 3.10.1 kernel.
> > 
> 
> Kernel panic? Weird.. I suspect something _else_ is wrong. I suggest trying
> out the following:
> 
> 1. My patches only touch cpufreq. So completely turn off cpufreq by setting
>    CONFIG_CPU_FREQ=n. Then try suspend/resume and see how it goes. If it
>    fails, that shows that something _else_ is wrong and you can try a git
>    bisect for that.
I changed my config like shown below. That one has a two out of two
success rate for suspend/resume so far.

> 
>    However, if suspend/resume succeeds with CONFIG_CPU_FREQ=n, then try out
>    step 2 below.
> 
> 2. Apply patch 1 (not the entire patchset)
>    https://lkml.org/lkml/2013/7/11/661
That's the one I already have in my tree

> 
>    On top of that, apply this patch:
>    https://patchwork.kernel.org/patch/2827512/
This one does not apply. I'll see if I can make it apply.

>
> 
>    And then try suspend/resume with cpufreq turned on CONFIG_CPU_FREQ=y
>    (and turning on other cpufreq Kconfig options which are of interest to
>     you).
> 
> 
> That should help us narrow down whether the suspend/resume issue is really
> related to cpufreq or not.

Config diff:
--- /boot/config-3.10.1-custom-00001-g14bc9ec   2013-07-15 19:26:02.000000000 -0700
+++ /boot/config-3.10.1-no_cpufreq-00001-g14bc9ec       2013-07-16 22:21:22.000000000 -0700
@@ -48,7 +48,7 @@
 #
 CONFIG_INIT_ENV_ARG_LIMIT=32
 CONFIG_CROSS_COMPILE=""
-CONFIG_LOCALVERSION="-custom"
+CONFIG_LOCALVERSION="-no_cpufreq"
 CONFIG_LOCALVERSION_AUTO=y
 CONFIG_HAVE_KERNEL_GZIP=y
 CONFIG_HAVE_KERNEL_BZIP2=y
@@ -538,36 +538,7 @@
 #
 # CPU Frequency scaling
 #
-CONFIG_CPU_FREQ=y
-CONFIG_CPU_FREQ_TABLE=y
-CONFIG_CPU_FREQ_GOV_COMMON=y
-CONFIG_CPU_FREQ_STAT=y
-CONFIG_CPU_FREQ_STAT_DETAILS=y
-# CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE is not set
-# CONFIG_CPU_FREQ_DEFAULT_GOV_POWERSAVE is not set
-# CONFIG_CPU_FREQ_DEFAULT_GOV_USERSPACE is not set
-CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y
-# CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE is not set
-CONFIG_CPU_FREQ_GOV_PERFORMANCE=y
-CONFIG_CPU_FREQ_GOV_POWERSAVE=y
-CONFIG_CPU_FREQ_GOV_USERSPACE=y
-CONFIG_CPU_FREQ_GOV_ONDEMAND=y
-CONFIG_CPU_FREQ_GOV_CONSERVATIVE=y
-
-#
-# x86 CPU frequency scaling drivers
-#
-# CONFIG_X86_INTEL_PSTATE is not set
-# CONFIG_X86_PCC_CPUFREQ is not set
-CONFIG_X86_ACPI_CPUFREQ=y
-# CONFIG_X86_POWERNOW_K8 is not set
-CONFIG_X86_SPEEDSTEP_CENTRINO=y
-# CONFIG_X86_P4_CLOCKMOD is not set
-
-#
-# shared options
-#
-# CONFIG_X86_SPEEDSTEP_LIB is not set
+# CONFIG_CPU_FREQ is not set
 CONFIG_CPU_IDLE=y
 # CONFIG_CPU_IDLE_MULTIPLE_DRIVERS is not set
 CONFIG_CPU_IDLE_GOV_LADDER=y
@@ -2911,7 +2882,6 @@
 # CONFIG_THERMAL_GOV_FAIR_SHARE is not set
 CONFIG_THERMAL_GOV_STEP_WISE=y
 CONFIG_THERMAL_GOV_USER_SPACE=y
-CONFIG_CPU_THERMAL=y
 # CONFIG_THERMAL_EMULATION is not set
 # CONFIG_INTEL_POWERCLAMP is not set
 CONFIG_WATCHDOG=y

 	Sören

Content of type "application/pgp-signature" skipped

Powered by blists - more mailing lists