| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20130717.182237.906875287830581782.davem@davemloft.net> Date: Wed, 17 Jul 2013 18:22:37 -0700 (PDT) From: David Miller <davem@...emloft.net> To: geert@...ux-m68k.org Cc: sammy@...my.net, netdev@...r.kernel.org, linux-m68k@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net/sun3_82586: Kill array subscript above array bounds warning From: Geert Uytterhoeven <geert@...ux-m68k.org> Date: Wed, 17 Jul 2013 14:25:05 +0200 > drivers/net/ethernet/i825xx/sun3_82586.c: In function 'sun3_82586_timeout': > drivers/net/ethernet/i825xx/sun3_82586.c:993:89: warning: array subscript is above array bounds [-Warray-bounds] > > Using the default NUM_XMIT_BUFFS = 1, there's only one transmit buffer. > Hence accessing the second buffer is an out-of-bounds access. > Print the command status of the first NOP buffer instead. > > Fortunately this actually worked fine, as the layout of transmit and NOP > buffers is sufficiently similar. > > Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org> Three more CPP directives in a DEBUG ifdef'd piece of code, yuck. I'd say just kill this whole DEBUG section entirely. If people want this driver to print this debugging, do it properly with netif_err() or similar. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists