linux-kernel - Re: [PATCH] regulator: core: Use the power efficient workqueue for delayed powerdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKohpo=VqJA7m_p7YSNZjkY6Se640RJEHSdJdX6BwY+VGSfAng@mail.gmail.com>
Date:	Thu, 18 Jul 2013 16:26:22 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Mark Brown <broonie@...nel.org>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	linaro-kernel@...ts.linaro.org, linux-kernel@...r.kernel.org,
	Mark Brown <broonie@...aro.org>
Subject: Re: [PATCH] regulator: core: Use the power efficient workqueue for
 delayed powerdown

On 18 July 2013 16:23, Mark Brown <broonie@...nel.org> wrote:
> From: Mark Brown <broonie@...aro.org>
>
> There is no need to use a normal per-CPU workqueue for delayed power downs
> as they're not timing or performance critical and waking up a core for them
> would defeat some of the point.
>
> Signed-off-by: Mark Brown <broonie@...aro.org>
> ---
>  drivers/regulator/core.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index b6efead..6ef476f 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -1891,8 +1891,9 @@ int regulator_disable_deferred(struct regulator *regulator, int ms)
>         rdev->deferred_disables++;
>         mutex_unlock(&rdev->mutex);
>
> -       ret = schedule_delayed_work(&rdev->disable_work,
> -                                   msecs_to_jiffies(ms));
> +       ret = queue_delayed_work(system_power_efficient_wq,
> +                                &rdev->disable_work,
> +                                msecs_to_jiffies(ms));
>         if (ret < 0)
>                 return ret;
>         else

Cool!! People have started to use this interface now :)

Reviewed-by: Viresh Kumar <viresh.kumar@...aro.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/