linux-kernel - Re: [PATCH] usb: udc: add gadget state kobject uevent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Jul 2013 14:06:28 +0300
From:	Felipe Balbi <balbi@...com>
To:	Rong Wang <wr011235813@...il.com>
CC:	<balbi@...com>, Greg KH <gregkh@...uxfoundation.org>,
	Arnd Bergmann <arnd@...db.de>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <Rong.Wang@....com>
Subject: Re: [PATCH] usb: udc: add gadget state kobject uevent

On Thu, Jul 18, 2013 at 06:54:38PM +0800, Rong Wang wrote:
> Hi Felipe,
> 
> Here's the patch. If you are OK with it, I'll send it to the list formally.
> Thanks.
> 
> -------------------------------------------------------------------------------------------------
> 
> usb: gadget: udc-core: make udc state attribute name consistent
> 
> The name of udc state attribute file under sysfs is
> registered as "state", while usb_gadget_set_state
> take it as "status" when it's going to update.
> Here it is made consistent as "state".
> 
> Signed-off-by: Rong Wang <Rong.Wang@....com>
> 
> diff --git a/drivers/usb/gadget/udc-core.c b/drivers/usb/gadget/udc-core.c
> index ffd8fa5..5514822 100644
> --- a/drivers/usb/gadget/udc-core.c
> +++ b/drivers/usb/gadget/udc-core.c
> @@ -105,7 +105,7 @@ void usb_gadget_set_state(struct usb_gadget *gadget,
>                 enum usb_device_state state)
>  {
>         gadget->state = state;
> -       sysfs_notify(&gadget->dev.kobj, NULL, "status");
> +      sysfs_notify(&gadget->dev.kobj, NULL, "state");

just fix the indentation and prevent gmail from mangling the tabs into
spaces, you're good to go :-)

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)