linux-kernel - Re: [PATCH] ioatdma: silence GCC warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1374147757.26384.49.camel@x61.thuisdomein>
Date:	Thu, 18 Jul 2013 13:42:37 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Dan Williams <djbw@...com>
Cc:	Vinod Koul <vinod.koul@...el.com>, linux-kernel@...r.kernel.org,
	"dave.jiang" <dave.jiang@...el.com>
Subject: Re: [PATCH] ioatdma: silence GCC warnings

On Wed, 2013-07-17 at 15:39 -0700, Dan Williams wrote:
> On Mon, Jun 17, 2013 at 3:35 AM, Paul Bolle <pebolle@...cali.nl> wrote:
> Seems this is fixed in gcc as of 4.7.2, but we can make things quieter
> for build testers on older compilers.

Well, I'm currently using
    gcc (GCC) 4.7.2 20121109 (Red Hat 4.7.2-8)

as shipped for Fedora 18.

> > diff --git a/drivers/dma/ioat/dma_v3.c b/drivers/dma/ioat/dma_v3.c
> > index ca6ea9b..b5102da 100644
> > --- a/drivers/dma/ioat/dma_v3.c
> > +++ b/drivers/dma/ioat/dma_v3.c
> > @@ -251,7 +251,7 @@ static bool is_bwd_noraid(struct pci_dev *pdev)
> >  }
> >
> >  static void pq16_set_src(struct ioat_raw_descriptor *desc[3],
> > -                       dma_addr_t addr, u32 offset, u8 coef, int idx)
> > +                       dma_addr_t addr, u32 offset, u8 coef, unsigned int idx)
> 
> "unsigned int" --> "unsigned"

Fine with me, but it does introduce a second form in this file (it
already uses "unsigned int" a few times).

> >  {
> >         struct ioat_pq_descriptor *pq = (struct ioat_pq_descriptor *)desc[0];
> >         struct ioat_pq16a_descriptor *pq16 =
> 
> Just do this hunk as the minimal one line change.

You're right. Just this hunk is enough. I'll try to send a v2 shortly.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/