linux-kernel - Re: [PATCH 02/23] perf tools: Remove data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Jul 2013 14:46:01 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	linux-kernel@...r.kernel.org,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>, Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Andi Kleen <ak@...ux.intel.com>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 02/23] perf tools: Remove data_offset seek as it's not
 needed

On Thu, Jul 18, 2013 at 04:27:47PM +0900, Namhyung Kim wrote:
> On Wed, 17 Jul 2013 19:49:42 +0200, Jiri Olsa wrote:
> > Removing data_offset seek as it's not needed, because
> > data are not read by syscall but mmaped instead.
> 
> Yes we do, but it's not mandatory, right?  I'd rather expect the file
> offset remains at the beginning of data after calling
> perf_session__read_header() instead of a random point (EOF?).

well it's just useless, and I think it's better and more clear
to set it properly before the reading anyway. Also AFAICS there's
no other read after this seek even later.

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/