linux-kernel - Re: [PATCH v2 5/5] media: davinci: vpbe: Replace printk with dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+V-a8vBzRnRXhvaLGsQMDhKEAyNDRvnd4QZQ0xnUUo-D3Ek2A@mail.gmail.com>
Date:	Thu, 18 Jul 2013 21:15:15 +0530
From:	Prabhakar Lad <prabhakar.csengg@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	LMML <linux-media@...r.kernel.org>,
	DLOS <davinci-linux-open-source@...ux.davincidsp.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 5/5] media: davinci: vpbe: Replace printk with dev_*

Hi Joe,

On Thu, Jul 18, 2013 at 9:10 PM, Joe Perches <joe@...ches.com> wrote:
> On Thu, 2013-07-18 at 20:59 +0530, Prabhakar Lad wrote:
>> Use the dev_* message logging API instead of raw printk.
> []
>> diff --git a/drivers/media/platform/davinci/vpbe.c b/drivers/media/platform/davinci/vpbe.c
> []
>> @@ -595,7 +595,7 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)
>>        * matching with device name
>>        */
>>       if (NULL == vpbe_dev || NULL == dev) {
>> -             printk(KERN_ERR "Null device pointers.\n");
>> +             dev_err(dev, "Null device pointers.\n");
>
> And if dev actually is NULL?
>
Ah nice catch, I overlooked it, I'll fix it.

Regards,
--Prabhakar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/