linux-kernel - RE: BUG: key ffff880c1148c478 not in .data! (V3.10.0)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3908561D78D1C84285E8C5FCA982C28F31C92B23@ORSMSX106.amr.corp.intel.com>
Date:	Thu, 18 Jul 2013 16:51:48 +0000
From:	"Luck, Tony" <tony.luck@...el.com>
To:	Borislav Petkov <bp@...en8.de>
CC:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	Markus Trippelsdorf <markus@...ppelsdorf.de>,
	Ming Lei <tom.leiming@...il.com>, Linda Walsh <lkml@...nx.org>,
	Linux-Kernel <linux-kernel@...r.kernel.org>,
	Doug Thompson <dougthompson@...ssion.com>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>
Subject: RE: BUG: key ffff880c1148c478 not in .data! (V3.10.0)

+	BUG_ON(mci->mc_idx >= EDAC_MAX_MCS);

Do we have to "BUG_ON()" here?  Couldn't we be gentler with something like:

	if (mci->mc_idx >= EDAC_MAX_MCS) {
		printk_once(KERN_WARNING "Too many memory controllers\n");
		return; /* probably need to make sure caller copes with this ... so more stuff there */
	}

-Tony