linux-kernel - Re: [PATCH 02/51] Input: atmel_mxt_ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130718171131.GA32381@polaris.bitmath.org>
Date:	Thu, 18 Jul 2013 19:11:31 +0200
From:	rydberg@...omail.se
To:	Nick Dyer <nick.dyer@...ev.co.uk>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Daniel Kurtz <djkurtz@...omium.org>,
	Joonyoung Shim <jy0922.shim@...sung.com>,
	Alan Bowens <Alan.Bowens@...el.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Peter Meerwald <pmeerw@...erw.net>,
	Benson Leung <bleung@...omium.org>,
	Olof Johansson <olofj@...omium.org>
Subject: Re: [PATCH 02/51] Input: atmel_mxt_ts - Improve T19 GPIO keys
 handling

On Thu, Jun 27, 2013 at 01:48:37PM +0100, Nick Dyer wrote:
> 
>  * The mapping of the GPIO numbers into the T19 status byte varies between
>    different maXTouch chips. Some have up to 7 GPIOs. Allowing a keycode array
>    of up to 8 items is simpler and more generic. So replace #define with
>    configurable number of keys which also allows the removal of is_tp.
>  * Rename platform data parameters to include "t19" to prevent confusion with
>    T15 key array.
>  * Probe aborts early on when pdata is NULL, so no need to check.
>  * Move "int i" to beginning of function (mixed declarations and code)
>  * Use API calls rather than __set_bit()
>  * Remove unused dev variable.
> 
> Signed-off-by: Nick Dyer <nick.dyer@...ev.co.uk>
> ---
>  drivers/input/touchscreen/atmel_mxt_ts.c |   44 ++++++++++++------------------
>  drivers/platform/x86/chromeos_laptop.c   |   17 ++++++++----
>  include/linux/i2c/atmel_mxt_ts.h         |    7 ++---
>  3 files changed, 30 insertions(+), 38 deletions(-)

    Reviewed-by: Henrik Rydberg <rydberg@...omail.se>

Thanks,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/