linux-kernel - Re: [PATCH 44/51] Input: atmel_mxt_ts - Handle reports from T47 Stylus object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130718172321.GH32381@polaris.bitmath.org>
Date:	Thu, 18 Jul 2013 19:23:21 +0200
From:	rydberg@...omail.se
To:	Nick Dyer <nick.dyer@...ev.co.uk>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Daniel Kurtz <djkurtz@...omium.org>,
	Joonyoung Shim <jy0922.shim@...sung.com>,
	Alan Bowens <Alan.Bowens@...el.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Peter Meerwald <pmeerw@...erw.net>,
	Benson Leung <bleung@...omium.org>,
	Olof Johansson <olofj@...omium.org>
Subject: Re: [PATCH 44/51] Input: atmel_mxt_ts - Handle reports from T47
 Stylus object

On Thu, Jun 27, 2013 at 01:49:19PM +0100, Nick Dyer wrote:
> Signed-off-by: Nick Dyer <nick.dyer@...ev.co.uk>
> Acked-by: Benson Leung <bleung@...omium.org>
> ---
>  drivers/input/touchscreen/atmel_mxt_ts.c |   16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
> index ee39683..ceb090a 100644
> --- a/drivers/input/touchscreen/atmel_mxt_ts.c
> +++ b/drivers/input/touchscreen/atmel_mxt_ts.c
> @@ -128,6 +128,9 @@ struct t9_range {
>  /* Define for MXT_PROCI_TOUCHSUPPRESSION_T42 */
>  #define MXT_T42_MSG_TCHSUP	(1 << 0)
>  
> +/* T47 Stylus */
> +#define MXT_TOUCH_MAJOR_T47_STYLUS	1
> +

Ok - normally, creating dummy values is not recommended, but for the
shared touch/stylys implementation there is obviously no alternative.

>  /* T63 Stylus */
>  #define MXT_T63_STYLUS_PRESS	(1 << 0)
>  #define MXT_T63_STYLUS_RELEASE	(1 << 1)
> @@ -696,6 +699,7 @@ static void mxt_proc_t9_message(struct mxt_data *data, u8 *message)
>  	int area;
>  	int amplitude;
>  	u8 vector;
> +	int tool;
>  
>  	/* do not report events if input device not yet registered */
>  	if (!data->enable_reporting)
> @@ -713,6 +717,7 @@ static void mxt_proc_t9_message(struct mxt_data *data, u8 *message)
>  		y >>= 2;
>  
>  	area = message[5];
> +
>  	amplitude = message[6];
>  	vector = message[7];
>  
> @@ -741,8 +746,17 @@ static void mxt_proc_t9_message(struct mxt_data *data, u8 *message)
>  			mxt_input_sync(input_dev);
>  		}
>  
> +		/* A reported size of zero indicates that the reported touch
> +		 * is a stylus from a linked Stylus T47 object. */
> +		if (area == 0) {
> +			area = MXT_TOUCH_MAJOR_T47_STYLUS;
> +			tool = MT_TOOL_PEN;
> +		} else {
> +			tool = MT_TOOL_FINGER;
> +		}
> +
>  		/* Touch active */
> -		input_mt_report_slot_state(input_dev, MT_TOOL_FINGER, 1);
> +		input_mt_report_slot_state(input_dev, tool, 1);
>  		input_report_abs(input_dev, ABS_MT_POSITION_X, x);
>  		input_report_abs(input_dev, ABS_MT_POSITION_Y, y);
>  		input_report_abs(input_dev, ABS_MT_PRESSURE, amplitude);
> -- 
> 1.7.10.4
> 

    Reviewed-by: Henrik Rydberg <rydberg@...omail.se>

Thanks,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/