linux-kernel - Re: [PATCH] kconfig: switch to "long long" for sanity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdVyyA43s=O_PoSKC75G49T71ZWLAQ2B1HKW1MSc=q5TZA@mail.gmail.com>
Date:	Thu, 18 Jul 2013 20:01:43 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Kees Cook <keescook@...omium.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Yann E. MORIN" <yann.morin.1998@...e.fr>,
	Michal Marek <mmarek@...e.cz>,
	Arve Hjønnevåg <arve@...roid.com>,
	linux-kbuild <linux-kbuild@...r.kernel.org>
Subject: Re: [PATCH] kconfig: switch to "long long" for sanity

On Thu, Jul 18, 2013 at 6:06 PM, Kees Cook <keescook@...omium.org> wrote:
> Instead of using "long" for kconfig "hex" and "range" values, which may
> change in size depending on the host architecture, use "long long". This
> will allow values greater than INT_MAX on 32-bit hosts when cross
> compiling.
>
> Signed-off-by: Kees Cook <keescook@...omium.org>

Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>
with one minor nit...

>  static void sym_validate_range(struct symbol *sym)
>  {
>         struct property *prop;
> -       long base, val, val2;
> +       long long base, val, val2;

strtoll() expects an "int" type for "base". This was changed to "long" in your
previous patch.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/