lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Jul 2013 13:30:55 -0500 From: Rob Herring <robherring2@...il.com> To: Sudeep KarkadaNagesha <Sudeep.KarkadaNagesha@....com> CC: Andrew Lunn <andrew@...n.ch>, "grant.likely@...aro.org" <grant.likely@...aro.org>, "rob.herring@...xeda.com" <rob.herring@...xeda.com>, Lorenzo Pieralisi <Lorenzo.Pieralisi@....com>, Russell King <linux@....linux.org.uk>, Jason Cooper <jason@...edaemon.net>, "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "devicetree-discuss@...ts.ozlabs.org" <devicetree-discuss@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "cpufreq@...r.kernel.org" <cpufreq@...r.kernel.org>, "Rafael J. Wysocki" <rjw@...k.pl>, Viresh Kumar <viresh.kumar@...aro.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: Re: [RFC PATCH v2 11/15] cpufreq: kirkwood-cpufreq: remove device tree parsing for cpu nodes On 07/18/2013 05:14 AM, Sudeep KarkadaNagesha wrote: > On 18/07/13 09:24, Sudeep KarkadaNagesha wrote: >> On 17/07/13 15:43, Andrew Lunn wrote: >>> On Wed, Jul 17, 2013 at 03:06:20PM +0100, Sudeep.KarkadaNagesha@....com wrote: >>>> From: Sudeep KarkadaNagesha <sudeep.karkadanagesha@....com> >>>> > [...] >>> Are we not going a bit backwards here? You are replacing two lines >>> with 10 lines. >>> >>> How about putting these 10 lines into some helper, >>> of_get_cpu_device()? It would be useful for spear, kirkwood and >>> imx6q, and maybe others. >>> >> Yes I realised that after making changes to this and pmac32 drivers. I >> have already made those changes in v3. I am waiting for more response >> before posting them. >> > I thought of placing this helper in include/linux/of_device.h but I see: > #include <linux/of_platform.h> /* temporary until merge */ > > Does this mean of_platform.h and of_device.h will be merged ? No, I think that was probably to avoid adding includes of of_platform.h for 100's of files. Maybe things are cleaned up enough to remove this line. > If so, which will be the final merged one ? I would like to avoid > changing all the header file inclusions later in users of this new helper. of_device.h is the right place. Rob > > Regards, > Sudeep > > > _______________________________________________ > devicetree-discuss mailing list > devicetree-discuss@...ts.ozlabs.org > https://lists.ozlabs.org/listinfo/devicetree-discuss > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists