linux-kernel - Re: [PATCH v4] power: new trace event to print device suspend and resume time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Jul 2013 12:42:40 -0700
From:	Joe Perches <joe@...ches.com>
To:	Shuah Khan <shuah.kh@...sung.com>
Cc:	len.brown@...el.com, pavel@....cz, rjw@...k.pl,
	gregkh@...uxfoundation.org, rostedt@...dmis.org,
	fweisbec@...il.com, mingo@...hat.com, paul.gortmaker@...driver.com,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	shuahkhan@...il.com
Subject: Re: [PATCH v4] power: new trace event to print device suspend and
 resume time

On Thu, 2013-07-18 at 13:22 -0600, Shuah Khan wrote:
> A new trace event is added to pm events to print time it takes to suspend and
> resume a device. It generates trace message that includes device, driver,
> parent information in addition to the type of pm ops invoked as well as the
> pm event and error status from the pm ops. Example trace below:

Hi again Shuah.

Thanks, this looks good to me now.

Here's just one new trivial bit.

> diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
[]
> @@ -56,6 +57,8 @@ static pm_message_t pm_transition;
[]
> +static char *pm_verb(int);

Instead of giving a prototype to a static, can
you move the static to this location instead?

It's a trivial function that just enumerates
the int and returns a descriptive char *

btw: it should be declared "const char *" too.

That could be a new patch if you're tired of
modifying this one.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/