linux-kernel - perf: support for named threads broken

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <51E8551C.5040708@gmail.com>
Date:	Thu, 18 Jul 2013 14:50:36 -0600
From:	David Ahern <dsahern@...il.com>
To:	Feng Tang <feng.tang@...el.com>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
CC:	LKML <linux-kernel@...r.kernel.org>
Subject: perf: support for named threads broken

Hi Feng:

I noticed today that support for named threads is busted in latest perf. 
git bisect shows the first bad commit as:

commit 73994dc158a24df4af77d0a76c9702f120f7a6ad
Author: Feng Tang <feng.tang@...el.com>
Date:   Wed Aug 8 17:57:52 2012 +0800

     perf script: Replace "struct thread" with "struct addr_location" as 
a parameter for "process_event()"

     Both perl and python script start processing events other than trace
     points, and it's useful to pass the resolved symbol and the dso info to
     the event handler in script for better analysis and statistics.

     Struct thread is already a member of struct addr_location, using
     addr_location will keep the thread info, while providing additional
     symbol and dso info if exist, so that the script itself doesn't need to
     bother to do the symbol resolving and dso searching work.


I conveniently cut-off the Tested-by and Acked-by from me ;-)
Clearly I did not test named threads.

Can you take a look?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/