linux-kernel - Re: [PATCH v2] kconfig: switch to "long long" for sanity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5j+FddNDgyrF1qMU5_SSODPJjYJrEXnog=J9CBMABiW_ng@mail.gmail.com>
Date:	Thu, 18 Jul 2013 15:01:02 -0700
From:	Kees Cook <keescook@...omium.org>
To:	"Yann E. MORIN" <yann.morin.1998@...e.fr>
Cc:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Michal Marek <mmarek@...e.cz>,
	Arve Hjønnevåg <arve@...roid.com>,
	linux-kbuild <linux-kbuild@...r.kernel.org>
Subject: Re: [PATCH v2] kconfig: switch to "long long" for sanity

On Thu, Jul 18, 2013 at 1:47 PM, Yann E. MORIN <yann.morin.1998@...e.fr> wrote:
> Kees, Geert, All,
>
> On 2013-07-18 22:00 +0200, Geert Uytterhoeven spake thusly:
>> On Thu, Jul 18, 2013 at 8:32 PM, Kees Cook <keescook@...omium.org> wrote:
>> > Instead of using "long" for kconfig "hex" and "range" values, which may
>> > change in size depending on the host architecture, use "long long". This
>> > will allow values greater than INT_MAX on 32-bit hosts when cross
>> > compiling.
>> >
>> > Signed-off-by: Kees Cook <keescook@...omium.org>
>>
>> Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>
> Ok, thanks, I'll take in my tree.
>
> Is it material for -rc-fixes, or can it wait in -for-next?
>
> My gut feelings is that it does not fix an existing breakage, but only a
> potential problem in the future, so it would be a candidate for
> -for-next. Agreed?

Correct. I'm not aware of anything in the tree that currently uses
>INT_MAX values in kconfig.

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/