linux-kernel - Re: [PATCH 3.11-rc1] crypto: Fix boot failure due to module dependency.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51E87DD4.3000907@zytor.com>
Date:	Thu, 18 Jul 2013 16:44:20 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
CC:	Tim Chen <tim.c.chen@...ux.intel.com>,
	Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
	herbert@...dor.hengli.com.au, linux-kernel@...r.kernel.org,
	linux-crypto@...r.kernel.org, ak <ak@...ux.intel.com>,
	rjw@...ysocki.net
Subject: Re: [PATCH 3.11-rc1] crypto: Fix boot failure due to module dependency.

On 07/18/2013 03:17 PM, Rafael J. Wysocki wrote:
>>
>> alias x86cpu:vendor:*:family:*:model:*:feature:*0081* crct10dif_pclmul
>>
>> This should cause udev to load the crct10dif_pclml module when cpu
>> support the PCLMULQDQ (feature code 0081).  I did my testing during
>> development on 3.10 and the module was indeed loaded.
>>
>> However, I found that the following commit under 3.11-rc1 broke
>> the mechanism after some bisection.
>>
>> commit ac212b6980d8d5eda705864fc5a8ecddc6d6eacc
>> Author: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>> Date:   Fri May 3 00:26:22 2013 +0200
>>
>>      ACPI / processor: Use common hotplug infrastructure
>>           Split the ACPI processor driver into two parts, one that is
>>      non-modular, resides in the ACPI core and handles the enumeration
>>      and hotplug of processors and one that implements the rest of the
>>      existing processor driver functionality.
>>      Rafael, can you check and see if this can be fixed so those
>> optimized
>> crypto modules for Intel cpu that support them can be loaded?
> 
> I think this is an ordering issue between udev startup and the time when
> devices are registered.
> 
> I wonder what happens if you put those modules into the initramfs image?
> 

OK, this bothers me on some pretty deep level... a set of changes
exclusively in drivers/acpi breaking functionality which had nothing to
do with ACPI, specifically CPU-feature-based module loading.

Please let me know what the investigation comes up with, or if I need to
get more directly involved.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/