linux-kernel - RE: [PATCH] crypto: remove double execution of the same test suite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 19 Jul 2013 06:52:43 +0000
From:	Gupta Ruchika-R66431 <R66431@...escale.com>
To:	Stoica Cristian-B18196 <B18196@...escale.com>,
	"herbert@...dor.hengli.com.au" <herbert@...dor.hengli.com.au>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Geanta Neag Horia Ioan-B05471 <B05471@...escale.com>,
	Stoica Cristian-B18196 <B18196@...escale.com>
Subject: RE: [PATCH] crypto: remove double execution of the same test suite

Reviewed-by: Ruchika Gupta <ruchika.gupta@...escale.com>

> -----Original Message-----
> From: linux-crypto-owner@...r.kernel.org [mailto:linux-crypto-
> owner@...r.kernel.org] On Behalf Of Cristian Stoica
> Sent: Thursday, July 18, 2013 9:27 PM
> To: herbert@...dor.hengli.com.au
> Cc: davem@...emloft.net; linux-crypto@...r.kernel.org; linux-
> kernel@...r.kernel.org; Geanta Neag Horia Ioan-B05471; Stoica Cristian-
> B18196
> Subject: [PATCH] crypto: remove double execution of the same test suite
> 
> This patch removes redundant execution of the same test suite in cases where
> alg and driver variables are the same (e.g. when alg_test is called from
> tcrypt_test)
> 
> Signed-off-by: Cristian Stoica <cristian.stoica@...escale.com>
> ---
>  crypto/testmgr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/crypto/testmgr.c b/crypto/testmgr.c index 2f00607..e091ef6
> 100644
> --- a/crypto/testmgr.c
> +++ b/crypto/testmgr.c
> @@ -3234,7 +3234,7 @@ int alg_test(const char *driver, const char *alg, u32
> type, u32 mask)
>  	if (i >= 0)
>  		rc |= alg_test_descs[i].test(alg_test_descs + i, driver,
>  					     type, mask);
> -	if (j >= 0)
> +	if (j >= 0 && j != i)
>  		rc |= alg_test_descs[j].test(alg_test_descs + j, driver,
>  					     type, mask);
> 
> --
> 1.8.1.5
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/