linux-kernel - Re: [PATCH] sysctl net: Keep tcp_syn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51E94841.1020202@cogentembedded.com>
Date:	Fri, 19 Jul 2013 18:08:01 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Michal Tesar <mtesar@...hat.com>
CC:	davem@...emloft.net, kuznet@....inr.ac.ru, jmorris@...ei.org,
	yoshfuji@...ux-ipv6.org, kaber@...sh.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sysctl net: Keep tcp_syn_retries inside the boundary

Hello.

On 19-07-2013 14:47, Michal Tesar wrote:

> Limit the min/max value passed to the
> /proc/sys/net/ipv4/tcp_syn_retries.

> Signed-off-by: Michal Tesar <mtesar@...hat.com>
> ---
>   net/ipv4/sysctl_net_ipv4.c |    6 +++++-
>   1 files changed, 5 insertions(+), 1 deletions(-)

> diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c
> index b2c123c..fdc2a17 100644
> --- a/net/ipv4/sysctl_net_ipv4.c
> +++ b/net/ipv4/sysctl_net_ipv4.c
[...]
> @@ -332,7 +334,9 @@ static struct ctl_table ipv4_table[] = {
>   		.data		= &sysctl_tcp_syn_retries,
>   		.maxlen		= sizeof(int),
>   		.mode		= 0644,
> -		.proc_handler	= proc_dointvec
> +		.proc_handler	= proc_dointvec_minmax,
> +        .extra1     = &tcp_syn_retries_min,
> +        .extra2     = &tcp_syn_retries_max

    You should indent with tabs, not spaces.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/