linux-kernel - Re: [PATCH] lustre:libcfs: remove redundant code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOJsxLGEmjY6wTp99DKQ4ZKO2oXq6102MczbjCHTUReuCTq-fw@mail.gmail.com>
Date:	Fri, 19 Jul 2013 18:08:15 +0300
From:	Pekka Enberg <penberg@...nel.org>
To:	Alexandru Juncu <alexj@...edu.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	andreas.dilger@...el.com, tao.peng@....com,
	driverdev <devel@...verdev.osuosl.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] lustre:libcfs: remove redundant code.

On Fri, Jul 19, 2013 at 5:45 PM, Alexandru Juncu <alexj@...edu.org> wrote:
> Found using coccinelle. It suggested kmalloc/strcpy should be replaced
> with kstrdup, but the entire function can be replaced by kstrdup.
>
> Signed-off-by: Alexandru Juncu <alexj@...edu.org>
> ---
>  drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c b/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
> index 9edccc9..4dba304 100644
> --- a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
> +++ b/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
> @@ -135,18 +135,7 @@ EXPORT_SYMBOL(cfs_str2mask);
>  /* Duplicate a string in a platform-independent way */
>  char *cfs_strdup(const char *str, u_int32_t flags)
>  {
> -       size_t lenz; /* length of str + zero byte */
> -       char *dup_str;
> -
> -       lenz = strlen(str) + 1;
> -
> -       dup_str = kmalloc(lenz, flags);
> -       if (dup_str == NULL)
> -               return NULL;
> -
> -       memcpy(dup_str, str, lenz);
> -
> -       return dup_str;
> +       return kstrdup(str, flags);
>  }
>  EXPORT_SYMBOL(cfs_strdup);

It would be better if you replaced the calls to cfs_strdup() with
kstrdup() and got rid of cfs_strdup() altogether.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/