| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 19 Jul 2013 19:09:22 +0200 From: Alexandre Belloni <alexandre.belloni@...e-electrons.com> To: Hector Palacios <hector.palacios@...i.com> CC: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org, marex@...x.de, jic23@...nel.org, lars@...afoo.de, fabio.estevam@...escale.com Subject: Re: [PATCH v2 1/5] iio: mxs-lradc: change the realbits to 12 On 19/07/2013 11:13, Hector Palacios wrote: > The LRADC virtual channels have an 18 bit field to store the sum of up > to 2^5 accumulated samples. The read_raw function however only operates > over a single sample (12 bit resolution). > In order to use this field for scaling operations, we need it to be the > exact resolution value of the LRADC. > Besides, the driver was using an 18 bit mask (LRADC_CH_VALUE_MASK) to > report touch coordinates to userland. A 12 bit mask should be used instead > or else the touch libraries will expect a coordinates range between 0 > and 0x3ffff (18 bits), instead of between 0 and 0xfff (12 bits). > > Signed-off-by: Hector Palacios <hector.palacios@...i.com> > --- > Looks good to me: Acked-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com> -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists