linux-kernel - Re: [PATCH 1/1] tracing: Simplify trace_array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 19 Jul 2013 20:24:07 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Ingo Molnar <mingo@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] tracing: Simplify trace_array_get()

On 07/19, Steven Rostedt wrote:
>
> On Fri, 2013-07-19 at 19:20 +0200, Oleg Nesterov wrote:
>
> > Yes. But unless I missed something again this logic doesn't look exactly
> > correct. Because it seems that trace_array_get() can succeed when it
> > shoudn't.
> >
> > trace_array_get() can race with instance_delete() + new_instance_create(),
> > and _create()->kzalloc() can return the same memory which was freed by
> > _delete().
> >
> > No?
>
> Correct, but I don't see that as a major problem, do you?

Neither me. I should have mentioned this.

Except "might get a strange result" as you said.

But I have to admit, I am still trying to find something really bad ;)

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/