linux-kernel - Re: [PATCH] backports: backport drvdata = NULL core driver fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAB=NE6VHgure2+2VA=XWtaii4Wc_rG7YZ=_ZetgGnvouh7HJPw@mail.gmail.com>
Date:	Fri, 19 Jul 2013 14:08:21 -0700
From:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	"backports@...r.kernel.org" <backports@...r.kernel.org>,
	Hans de Goede <hdegoede@...hat.com>,
	Julia Lawall <julia.lawall@...6.fr>,
	USB list <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jiri Slaby <jslaby@...e.cz>, Jiri Kosina <jkosina@...e.cz>,
	Felix Fietkau <nbd@...nwrt.org>
Subject: Re: [PATCH] backports: backport drvdata = NULL core driver fixes

On Fri, Jul 19, 2013 at 2:07 PM, Luis R. Rodriguez
<mcgrof@...not-panic.com> wrote:
>> This is not a very good idea.  Although setting drvdata to NULL allowed
>> a lot of code to be removed, it also exposed a bunch of hidden bugs --
>> drivers were using the drvdata value even after their remove function
>> returned.
>
> Eek, have we not SmPL'ify'd a proof yet to ensure code like this no
> longer exists? Julia? :)

Come to think of it, perhaps we should require *proof* with SmPL like
this in future to avoid regressions ?

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/