linux-kernel - Re: [PATCH 2/3] gpio: add LP3943 I2C GPIO expander driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYVCrz_30HsX_4C5aFR0c3K4OzTXSo7gx_W39Ukpg8cpw@mail.gmail.com>
Date:	Sat, 20 Jul 2013 22:26:26 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	"Kim, Milo" <Milo.Kim@...com>
Cc:	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>,
	"thierry.reding@...il.com" <thierry.reding@...il.com>,
	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"lee.jones@...aro.org" <lee.jones@...aro.org>
Subject: Re: [PATCH 2/3] gpio: add LP3943 I2C GPIO expander driver

I forgot one thing:

On Tue, Jul 16, 2013 at 4:38 AM, Kim, Milo <Milo.Kim@...com> wrote:

> +static int lp3943_gpio_probe(struct platform_device *pdev)
> +{
> +       struct lp3943 *l = dev_get_drvdata(pdev->dev.parent);
> +       struct lp3943_gpio *lg;
> +       int ret;

This is where I want you to assign to a member of struct
lp3943 another u16 mask which tells which lines are
actually available for GPIO, and you should also add code to
make sure that lines that are not available fail gpio_request().

This configuration can probably be read out from the device
tree if you add the compatible node to the MFD cell when
registering it.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/