linux-kernel - Re: [PATCH] bridge: do not call setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130719.221334.1029630301322767269.davem@davemloft.net>
Date:	Fri, 19 Jul 2013 22:13:34 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	srivatsa.bhat@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
	tglx@...utronix.de, netdev@...r.kernel.org
Subject: Re: [PATCH] bridge: do not call setup_timer() multiple times

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 19 Jul 2013 20:07:16 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> commit 9f00b2e7cf24 ("bridge: only expire the mdb entry when query is
> received") added a nasty bug as an active timer can be reinitialized.
> 
> setup_timer() must be done once, no matter how many time mod_timer()
> is called. br_multicast_new_group() is the right place to do this.
> 
> Reported-by: Srivatsa S. Bhat <srivatsa.bhat@...ux.vnet.ibm.com>
> Diagnosed-by: Thomas Gleixner <tglx@...utronix.de>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Tested-by: Srivatsa S. Bhat <srivatsa.bhat@...ux.vnet.ibm.com>
> Cc: Cong Wang <amwang@...hat.com>

Applied, thanks a lot Eric.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/