linux-kernel - Re: [PATCH 00/15] iio: ti_am335x_adc: Add continuous mode take 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51EA73BC.8050901@kernel.org>
Date:	Sat, 20 Jul 2013 12:25:48 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Zubair Lutfullah <zubair.lutfullah@...il.com>
CC:	jic23@....ac.uk, gregkh@...uxfoundation.org,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
	koen@...inion.thruhere.net
Subject: Re: [PATCH 00/15] iio: ti_am335x_adc: Add continuous mode take 2



On 07/18/2013 11:21 PM, Zubair Lutfullah wrote:
> Patches now give correct authorship.
> 
> and checkpatch.pl issues are checked for each patch.
> 
> I hope the actual code bashing can begin now.
> 
> A series of patches that add continuous sampling support
> for the adc drivers for the am335x.
> 
> These apply on top of mfd-next after the recent set of patches
> on this driver by Sebastian Andrzej Siewior
> 
> Tested on the Beaglebone Black running 3.11
> 
> Patil, Rachna (5):
>   MFD: ti_tscadc: disable TSC config registers in adc mode
>   iio: ti_am335x_adc: Fix wrong samples received on 1st read
>   input: ti_tsc: Enable shared IRQ for TSC
>   iio: mfd: input: ti_am335x_adc:Add support for continuous mode
>   MFD: ti_tscadc: ADC Clock check not required
> 
> Russ Dill (10):
>   iio: ti_am335x_adc: Handle set to clear IRQENABLE
>   iio: ti_am335x_adc: Handle set to clear IRQSTATUS
>   iio: ti_am335x_adc: Handle overrun before threshold event
>   iio: ti_am335x_adc: Avoid double threshold event
>   iio: ti_am335x_adc: Also clear threshold event when clearing overrun
>     event
>   iio: ti_am335x_adc: Print error and handle short FIFO events
>   iio: ti_am335x_adc: Fix allocation count of FIFO buffer.
>   iio: ti_am335x_adc: Fix capture operation during resume
>   iio: ti_am335x_adc: Reset and clear overrun status before capture
>   iio: ti_am335x_adc: Properly handle out of memory situation

I am a little irritated by the mess we have here.  Russ has clearly done
a lot of fine work cleaning up the earlier patches.  As a result
we have a series of initial buggy patches and then a series of patches
fixing them again.

As you are submitting these for mainline I would really like it all merged
down into a clean series of clear patches.

Part 1.  Any fixes that are unconnected to the rest of the series.  These will
  then get sent upstream within this cycle.

Part 2. Feature add patch. Here that is basically a single patch adding the
  continous mode support.

It is nice to maintain history and all but I would much rather have something
that is easy to review, with appropriate comments or if people will give
them, sign offs to reflect the various contributions.

Jonathan


> 
>  drivers/iio/adc/ti_am335x_adc.c           |  354 +++++++++++++++++++++++++----
>  drivers/input/touchscreen/ti_am335x_tsc.c |   17 +-
>  drivers/mfd/ti_am335x_tscadc.c            |   30 ++-
>  include/linux/mfd/ti_am335x_tscadc.h      |   27 ++-
>  4 files changed, 366 insertions(+), 62 deletions(-)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/