linux-kernel - Re: [PATCH] ALSA: SoC: Added jack detection kcontrol support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 22 Jul 2013 01:01:58 +0100
From:	Mark Brown <broonie@...nel.org>
To:	"Felipe F. Tonello" <eu@...ipetonello.com>
Cc:	alsa-devel@...a-project.org, LiamGirdwoodlgirdwood@...il.com,
	JaroslavKyselaperex@...ex.cz, TakashiIwaitiwai@...e.de,
	linux-kernel@...r.kernel.org,
	"Felipe F. Tonello" <ftonello@...cacor.com>
Subject: Re: [PATCH] ALSA: SoC: Added jack detection kcontrol support

On Fri, Jul 19, 2013 at 05:59:22PM -0700, Felipe F. Tonello wrote:
> From: "Felipe F. Tonello" <ftonello@...cacor.com>
> 
> It adds soc jack support for alsa kcontrol.
> 
> This support is necessary since the new kcontrol is used by user-space
> daemons, such as PulseAudio(>=2.0), to do jack detection.
> 
> Signed-off-by: Felipe F. Tonello <ftonello@...cacor.com>
> ---
>  include/sound/soc.h  |  1 +
>  sound/soc/Kconfig    |  1 +
>  sound/soc/soc-jack.c | 22 ++++++++++++++++++++++
>  3 files changed, 24 insertions(+)

No, this makes no sense at all as an ASoC specific feature - it should
be a standard feature of ALSA jacks.  The whole point of having ALSA
core infrastructure for jacks is to avoid having to go round doing make
work stuff like this.

The fact that the kcontrols were introduced as a HDA-specific feature at
all is of course a problem here...

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)