linux-kernel - Re: [PATCH -tip 3/3] x86: Remove unused text_poke_smp and text_poke_smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130722074339.GA25976@gmail.com>
Date:	Mon, 22 Jul 2013 09:43:39 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Cc:	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Jiri Kosina <jkosina@...e.cz>,
	Steven Rostedt <rostedt@...dmis.org>,
	Jason Baron <jbaron@...mai.com>, yrl.pp-manager.tt@...achi.com,
	Borislav Petkov <bpetkov@...e.de>
Subject: Re: [PATCH -tip 3/3] x86: Remove unused text_poke_smp and
 text_poke_smp_batch


* Masami Hiramatsu <masami.hiramatsu.pt@...achi.com> wrote:

> Since introducing the text_poke_bp for all text_poke_smp*
> callers, text_poke_smp* are now unused. This basically
> reverts 3d55cc8a, 7deb18dc and related commits.
> 
> This also fixes a Kconfig dependency issue on STOP_MACHINE
> in the case of CONFIG_SMP && !CONFIG_MODULE_UNLOAD.
> 
> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
> ---
>  arch/x86/Kconfig                   |    5 --
>  arch/x86/include/asm/alternative.h |   11 ----
>  arch/x86/kernel/alternative.c      |   98 +-----------------------------------
>  3 files changed, 2 insertions(+), 112 deletions(-)

Hm, it does not build with the attached config:

arch/x86/kernel/kprobes/opt.c: In function 'setup_optimize_kprobe':
arch/x86/kernel/kprobes/opt.c:394:6: error: dereferencing pointer to incomplete type
arch/x86/kernel/kprobes/opt.c:395:6: error: dereferencing pointer to incomplete type
arch/x86/kernel/kprobes/opt.c:396:6: error: dereferencing pointer to incomplete type

Thanks,

	Ingo

View attachment "config" of type "text/plain" (90050 bytes)