linux-kernel - Re: [PATCH] open(2): document O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51ECF166.4080007@redhat.com>
Date:	Mon, 22 Jul 2013 10:46:30 +0200
From:	Peter Schiffer <pschiffe@...hat.com>
To:	Michael Kerrisk <mtk.manpages@...il.com>
CC:	Al Viro <viro@...IV.linux.org.uk>,
	lkml <linux-kernel@...r.kernel.org>,
	Mike Frysinger <vapier@...too.org>,
	"Theodore Ts'o" <tytso@....edu>,
	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
	linux-man <linux-man@...r.kernel.org>, benjamin@...hon.org
Subject: Re: [PATCH] open(2): document O_PATH

On 07/20/2013 10:56 PM, Michael Kerrisk wrote:
> On 07/20/13 13:40, Al Viro wrote:
>> On Thu, Mar 14, 2013 at 10:35:59AM +0100, Michael Kerrisk (man-pages) wrote:
>>> Hello Al et al,
>>>
>>> Documenting O_PATH fell by the wayside last year
>>> (http://thread.gmane.org/gmane.linux.man/2790) as I got distracted
>>> with other tasks. A recent prod or two have reminded me restart this.
>>> I have the following patch queued to document O_PATH.
>>>
>>> Could you please review. I've provided the O_PATH doc both as
>>> formatted text, for ease of reviewing, and as a patch and entire file
>>> (attached).
>>
>> Seems to be mostly correct; the only thing missing is that F_GETFL is also
>> allowed (and return value will contain O_PATH for such descriptors).  Had
>> been there since the very beginning...
>
> Thanks, Al. I have added that piece.
>

Michael,

there is a typo within added piece:

diff --git a/man2/open.2 b/man2/open.2
index c61ea7f..ef0f664 100644
--- a/man2/open.2
+++ b/man2/open.2
@@ -489,7 +489,7 @@ and
  .IP *
  Retrieving open file status flags using the
  .BR fcntl (2)
-.BR F_GETFD
+.BR F_GETFL
  operation: the returned flags will include the bit
  .BR O_PATH .


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/