linux-kernel - Re: [PATCH -tip 3/3] x86: Remove unused text_poke_smp and text_poke_smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51ED053C.1070105@hitachi.com>
Date:	Mon, 22 Jul 2013 19:11:08 +0900
From:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Jiri Kosina <jkosina@...e.cz>,
	Steven Rostedt <rostedt@...dmis.org>,
	Jason Baron <jbaron@...mai.com>, yrl.pp-manager.tt@...achi.com,
	Borislav Petkov <bpetkov@...e.de>
Subject: Re: [PATCH -tip 3/3] x86: Remove unused text_poke_smp and text_poke_smp_batch

(2013/07/22 19:01), Ingo Molnar wrote:
> 
> * Masami Hiramatsu <masami.hiramatsu.pt@...achi.com> wrote:
> 
>> (2013/07/22 17:21), Ingo Molnar wrote:
>>>
>>> * Ingo Molnar <mingo@...nel.org> wrote:
>>>
>>>>
>>>> * Masami Hiramatsu <masami.hiramatsu.pt@...achi.com> wrote:
>>>>
>>>>> Since introducing the text_poke_bp for all text_poke_smp*
>>>>> callers, text_poke_smp* are now unused. This basically
>>>>> reverts 3d55cc8a, 7deb18dc and related commits.
>>>>>
>>>>> This also fixes a Kconfig dependency issue on STOP_MACHINE
>>>>> in the case of CONFIG_SMP && !CONFIG_MODULE_UNLOAD.
>>>>>
>>>>> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
>>>>> ---
>>>>>  arch/x86/Kconfig                   |    5 --
>>>>>  arch/x86/include/asm/alternative.h |   11 ----
>>>>>  arch/x86/kernel/alternative.c      |   98 +-----------------------------------
>>>>>  3 files changed, 2 insertions(+), 112 deletions(-)
>>>>
>>>> Hm, it does not build with the attached config:
>>>>
>>>> arch/x86/kernel/kprobes/opt.c: In function 'setup_optimize_kprobe':
>>>> arch/x86/kernel/kprobes/opt.c:394:6: error: dereferencing pointer to incomplete type
>>>> arch/x86/kernel/kprobes/opt.c:395:6: error: dereferencing pointer to incomplete type
>>>> arch/x86/kernel/kprobes/opt.c:396:6: error: dereferencing pointer to incomplete type
>>>
>>> 32-bit appears to be the key pattern.
>>
>> Ingo, please make sure your x86/jumplabel tree picked all of my patches.
>> This 3/3 strongly depends on the previous 1/3 and 2/3.
>> Without it, kprobes/opt.c can not be build because it still uses the
>> text_poke_params data structure which 3/3 removes.
> 
> Yes I know, and it was on top of -tip which already had these included:
> 
>  51b2c07b2226 x86: Make jump_label use int3-based patching
>  fd4363fff3d9 x86: Introduce int3 (breakpoint)-based instruction patching
> 
> without these the third patch wouldn't even apply I think.

No, I meant below two patches:
 kprobes/x86: Remove an incorrect comment about int3 in NMI/MCE
 kprobes/x86: Use text_poke_bp() instead of text_poke_smp*()

Since the "setup_optimize_kprobe" in the error message is completely
*removed* by the second one, the above error should not happen.

Thank you,


-- 
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@...achi.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/