linux-kernel - Re: [PATCH v3] xen/arm: enable PV control for ARM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130722143920.GC32221@e106331-lin.cambridge.arm.com>
Date:	Mon, 22 Jul 2013 15:39:20 +0100
From:	Mark Rutland <mark.rutland@....com>
To:	Stefano Stabellini <stefano.stabellini@...citrix.com>
Cc:	Julien Grall <julien.grall@...aro.org>,
	"konrad.wilk@...cle.com" <konrad.wilk@...cle.com>,
	"ian.campbell@...rix.com" <ian.campbell@...rix.com>,
	"patches@...aro.org" <patches@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"xen-devel@...ts.xen.org" <xen-devel@...ts.xen.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Catalin Marinas <Catalin.Marinas@....com>
Subject: Re: [PATCH v3] xen/arm: enable PV control for ARM

On Mon, Jul 22, 2013 at 03:09:35PM +0100, Stefano Stabellini wrote:
> On Mon, 22 Jul 2013, Mark Rutland wrote:
> > Hi,
> > 
> > [Adding Catalin to Cc]
> > 
> > On Mon, Jul 22, 2013 at 11:57:34AM +0100, Julien Grall wrote:
> > > Enable power management from the toolstack for ARM guest.
> > > 
> > > Signed-off-by: Julien Grall <julien.grall@...aro.org>
> > > 
> > > ---
> > >     Changes in v3:
> > >         - Fix condition to compile cpu_hotplug.o
> > >     Changes in v2:
> > >         - Don't compile xen/cpu_hotplug.o with ARM64
> > 
> > My arm64 cpu hotplug series is going to be dependent on not compiling
> > xen/cpu_hotplug.o. Currently I'm not able to compile an arm64 kernel
> > with my patches and Xen support.
> > 
> > How do you intend to push this? I'd like to ensure my cpu hotplug series
> > is able to go in for the next merge window.
> 
> This patch does exactly that: it makes sure cpu_hotplug is not compiled
> on ARM64.

Sorry, what I meant was that my series is going to be entirely dependent
on this patch or it'll break bisection. That'll make merging things a
little painful as I'll need a stable branch with this patch to base my
series upon.

Another option would be to split this patch into two parts, one enabling
power management and one fixing things up for HOTPLUG_CPU on arm64. That
way I could take the arm64 HOTPLUG_CPU fix in my series adding arm64
HOTPLUG_CPU support.

Would that be acceptable? Have I missed something?

> Given that this patch is for drivers/xen/Makefile, normally it goes via
> Konrad's tree.
> 
> 
> > > ---
> > >  drivers/xen/Makefile |    5 ++---
> > >  1 file changed, 2 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
> > > index 2bf461a..f185e8d 100644
> > > --- a/drivers/xen/Makefile
> > > +++ b/drivers/xen/Makefile
> > > @@ -1,9 +1,8 @@
> > > -ifneq ($(CONFIG_ARM),y)
> > > -obj-y	+= manage.o
> > > +ifeq ($(filter y, $(CONFIG_ARM) $(CONFIG_ARM64)),)
> > >  obj-$(CONFIG_HOTPLUG_CPU)		+= cpu_hotplug.o
> > >  endif
> > 
> > Might it make sense to enable this based on a list the architectures
> > that actually need this, rather than disabling it based on the list of
> > architectures that don't?
> 
> This is more philosophical than practical, but I would expect this
> limitation to go away soon, and be able to compile cpu_hotplug without
> issues on ARM and ARM64 too.
> 

Ok, that's fine then.

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/