linux-kernel - infiniband build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130722013758.GA14337@google.com>
Date:	Sun, 21 Jul 2013 18:37:58 -0700
From:	Michel Lespinasse <walken@...gle.com>
To:	Sean Hefty <sean.hefty@...el.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: infiniband build warning

Hi,

I am seeing build warnings in drivers/infiniband/core/cma.c starting with v3.11-rc1. These can be reproduced with gcc 4.6.3.

Would you consider applying the following fix ?
(The compiler warning seems benign as I could easily convince myself that the variable won't be used uninitialized, but I'd like to get rid of the compiler warning anyway).

--------------------------------- 8< ------------------------------------
infiniband: fix maybe-uninitialized warning in rdma_resolve_addr()

This fixes the following warning:

drivers/infiniband/core/cma.c: In function 'rdma_resolve_addr':
drivers/infiniband/core/cma.c:465:23: error: 'port' may be used uninitialized in this function [-Werror=maybe-uninitialized]
drivers/infiniband/core/cma.c:426:5: note: 'port' was declared here

The warning looks benign: port is only used after checking that
cma_dev is not NULL, and all assignments to cma_dev also set port.

diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index f1c279fabe64..7b2e38ad1243 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -423,7 +423,7 @@ static int cma_resolve_ib_dev(struct rdma_id_private *id_priv)
 	struct sockaddr_ib *addr;
 	union ib_gid gid, sgid, *dgid;
 	u16 pkey, index;
-	u8 port, p;
+	u8 port = 0, p;
 	int i;
 
 	cma_dev = NULL;

-- 
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/