linux-kernel - Re: [PATCH 07/22] ARM: exynos: Remove '0x's from Exynos4110 DTSI file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2350088.9z671SCjFz@flatron>
Date:	Mon, 22 Jul 2013 21:25:35 +0200
From:	Tomasz Figa <tomasz.figa@...il.com>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	arnd@...db.de, linus.walleij@...ricsson.com,
	Kukjin Kim <kgene.kim@...sung.com>,
	linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH 07/22] ARM: exynos: Remove '0x's from Exynos4110 DTSI file

Hi Lee,

On Monday 22 of July 2013 11:52:26 Lee Jones wrote:
> Cc: Kukjin Kim <kgene.kim@...sung.com>
> Cc: linux-samsung-soc@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  arch/arm/boot/dts/exynos4210.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4210.dtsi
> b/arch/arm/boot/dts/exynos4210.dtsi index b7f358a..53e2527 100644
> --- a/arch/arm/boot/dts/exynos4210.dtsi
> +++ b/arch/arm/boot/dts/exynos4210.dtsi
> @@ -72,7 +72,7 @@
>  		};
>  	};
> 
> -	clock: clock-controller@...0030000 {
> +	clock: clock-controller@...30000 {
>  		compatible = "samsung,exynos4210-clock";
>  		reg = <0x10030000 0x20000>;
>  		#clock-cells = <1>;

This looks fine, but please fix commit message - it should be Exynos4210. 
Also some explanation why this change is needed would be good, even if 
it's obvious.

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/