linux-kernel - Re: [PATCH V3] gpio: palmas: add dt support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51EDAB0A.8080601@nvidia.com>
Date:	Mon, 22 Jul 2013 14:58:34 -0700
From:	Stephen Warren <swarren@...dia.com>
To:	Laxman Dewangan <ldewangan@...dia.com>
CC:	linus.walleij@...aro.org, grant.likely@...aro.org,
	rob.herring@...xeda.com, rob@...dley.net,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
	kishon@...com, j-keerthy@...com, gg@...mlogic.co.uk
Subject: Re: [PATCH V3] gpio: palmas: add dt support

On 07/21/2013 10:12 PM, Laxman Dewangan wrote:
> Add of_device_id table for Palma GPIO to be enable the
> driver from DT file.
> 
> The driver can be registered from DT file as:
> 	palmas: tps65913@58 {
> 		:::::::::::
> 		palmas_gpio: palmas_gpio {
> 			compatible = "ti,palmas-gpio";
> 			gpio-controller;
> 			#gpio-cells = <2>;
> 		};
> 	};
> 
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>

> diff --git a/Documentation/devicetree/bindings/gpio/gpio-palmas.txt b/Documentation/devicetree/bindings/gpio/gpio-palmas.txt

> +- #gpio-cells : Should be two.
> +  - first cell is the gpio pin number
> +  - second cell is used to specify optional parameters (unused)

Shouldn't the second cell contain the standard GPIO-related flags such
as bit 0 == active-low?

Aside from that, this binding and indeed the rest of the patch looks
fine to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/