linux-kernel - Re: workqueue, pci: INFO: possible recursive locking detected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQWS7Q0Snv=ZOs8UpYv_re_AW6zRYbcMU08UQBKZogMjFQ@mail.gmail.com>
Date:	Mon, 22 Jul 2013 15:06:25 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Tejun Heo <tj@...nel.org>, "Rafael J. Wysocki" <rjw@...k.pl>,
	Alexander Duyck <alexander.h.duyck@...el.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: Re: workqueue, pci: INFO: possible recursive locking detected

On Mon, Jul 22, 2013 at 2:38 PM, Bjorn Helgaas <bhelgaas@...gle.com> wrote:
> [+cc Alex, Yinghai, linux-pci]

>
> Isn't this for the same issue Alex and others have been working on?

yes.

>
> It doesn't feel like we have consensus on how this should be fixed.
> You're proposing a change to work_on_cpu(), Alex proposed a change to
> pci_call_probe() [1], Yinghai proposed some changes to the PCI core
> SR-IOV code and several drivers [2].
>
> [1] https://lkml.kernel.org/r/20130624195942.40795.27292.stgit@ahduyck-cp1.jf.intel.com
> [2] https://lkml.kernel.org/r/1368498506-25857-7-git-send-email-yinghai@kernel.org

Actually i used Alex's patch and attached -v2 of sriov_attatch in my
local testing for a while. -v2: remove the device_schedule_callback
hacking.

Also, someone comment that numa_node_id() in alex's should not be
used, as it could
be preempted.

Thanks

Yinghai

Download attachment "fix_racing_removing_6_6.patch" of type "application/octet-stream" (14647 bytes)