linux-kernel - [PATCH 1/1 v2] x86, acpi: Fix wrong checking condition in acpi_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1374566419-21120-1-git-send-email-tangchen@cn.fujitsu.com>
Date:	Tue, 23 Jul 2013 16:00:19 +0800
From:	Tang Chen <tangchen@...fujitsu.com>
To:	len.brown@...el.com, pavel@....cz, rjw@...k.pl, tglx@...utronix.de,
	mingo@...hat.com, hpa@...or.com, x86@...nel.org,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH 1/1 v2] x86, acpi: Fix wrong checking condition in acpi_register_lapic().

We wanted to check if the acpi id is out of range. It should be:
	if (id >= MAX_LOCAL_APIC).

v1 -> v2:
Remove the superfluous parentheses around MAX_LOCAL_APIC.

Signed-off-by: Tang Chen <tangchen@...fujitsu.com>
Reviewed-by: Len Brown <len.brown@...el.com>
---
 arch/x86/kernel/acpi/boot.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
index d81a972..256479d 100644
--- a/arch/x86/kernel/acpi/boot.c
+++ b/arch/x86/kernel/acpi/boot.c
@@ -199,7 +199,7 @@ static void __cpuinit acpi_register_lapic(int id, u8 enabled)
 {
 	unsigned int ver = 0;
 
-	if (id >= (MAX_LOCAL_APIC-1)) {
+	if (id >= MAX_LOCAL_APIC) {
 		printk(KERN_INFO PREFIX "skipped apicid that is too big\n");
 		return;
 	}
-- 
1.7.10.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/