linux-kernel - Re: [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for DT usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130723085346.GQ24642@n2100.arm.linux.org.uk>
Date:	Tue, 23 Jul 2013 09:53:46 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Jean-Francois Moine <moinejf@...e.fr>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Rob Herring <rob.herring@...xeda.com>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	devicetree-discuss@...r.kernel.org
Subject: Re: [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for
	DT usage

On Tue, Jul 23, 2013 at 10:46:15AM +0200, Jean-Francois Moine wrote:
> The kirkwood i2s driver is used without DT in the Kirkwood machine.
> This patch adds a DT compatible definition for use in other Marvell
> machines as the Armada 88AP510 (Dove).

Yet again, this illustrates why converting to DT causes backwards
steps in drivers: the conversion of devm_clk_get() to of_clk_get()
necessitates a clk_put().

Can someone please provide a devm_of_clk_get() function before we
accept any more patches doing this kind of thing?

The other issue is that kirkwood-dma.c and kirkwood-i2s.c should be
one driver; they're not separate hardware on these platforms, so that
needs fixing before coming up with any kind of DT model for this stuff.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/