linux-kernel - Re: [PATCH] Staging: bcm: Qos: Fix some coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1374574241.17286.8.camel@desktop>
Date:	Tue, 23 Jul 2013 18:10:41 +0800
From:	Lilis Iskandar <veeableful@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: bcm: Qos: Fix some coding style issues

Hi Dan,

I have already accepted my fate when I submitted the patch. Though it's
really great that I receive a response so fast :)

Regarding the braces, I thought it would be more readable that way
because of the long code wrapping inside the "if" parameter. I'll fix it
and send the patches again in pieces. Should I send a new mail or reply
to this thread?

Lilis

On Tue, 2013-07-23 at 12:54 +0300, Dan Carpenter wrote:
> Hi hi,
> 
> Welcome first time submitter newbie.  :)  The tradition is to reject
> first time code submissions in the meanest and grumpiest way
> possible.
> 
> On Tue, Jul 23, 2013 at 05:20:29PM +0800, Lilis Iskandar wrote:
> > >From a2f8b299baee0e075d548d2bbf77619373035446 Mon Sep 17 00:00:00 2001
> > From: Lilis Iskandar <veeableful@...il.com>
> > Date: Tue, 23 Jul 2013 17:08:37 +0800
> > Subject: [PATCH] Staging: bcm: Qos: Fix some coding style issues
> 
> This header stuff is not needed.  See if you can figure out how to
> get rid of it.
> 
> You are fixing too many kinds of problems at once so the patch is
> impossible to review.  Please break it up into one kind of issue
> per patch.
> 
> > -		if(FALSE == (bClassificationSucceed =
> > +		if (FALSE == (bClassificationSucceed =
> >  			MatchSrcPort(pstClassifierRule,
> > -				ntohs((iphd->protocol == UDP)?
> > -				xprt_hdr->uhdr.source:xprt_hdr->thdr.source))))
> > +			ntohs((iphd->protocol == UDP)?
> > +			xprt_hdr->uhdr.source : xprt_hdr->thdr.source))))
> > +		{
> >  			break;
> > +		}
> 
> I don't know why you are adding curly braces here but they don't
> belong.  Braces are explained in CodingStyle.
> 
> regards,
> dan carpenter
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/