linux-kernel - Re: [PATCH v4] xen/arm: enable PV control for ARM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1307231235510.4893@kaball.uk.xensource.com>
Date:	Tue, 23 Jul 2013 12:37:04 +0100
From:	Stefano Stabellini <stefano.stabellini@...citrix.com>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
CC:	Julien Grall <julien.grall@...aro.org>,
	<stefano.stabellini@...citrix.com>, <ian.campbell@...rix.com>,
	<patches@...aro.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <xen-devel@...ts.xen.org>
Subject: Re: [PATCH v4] xen/arm: enable PV control for ARM

On Mon, 22 Jul 2013, Konrad Rzeszutek Wilk wrote:
> Julien Grall <julien.grall@...aro.org> wrote:
> >Enable power management from the toolstack for ARM guest.
> >
> >Signed-off-by: Julien Grall <julien.grall@...aro.org>
> >
> >---
> >    Changes in v4:
> >        - Divide the patch in 2 distinct parts
> >    Changes in v3:
> >        - Fix condition to compile cpu_hotplug.o
> >    Changes in v2:
> >        - Don't compile xen/cpu_hotplug.o with ARM64
> >---
> > drivers/xen/Makefile |    3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> >diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
> >index a609353..f185e8d 100644
> >--- a/drivers/xen/Makefile
> >+++ b/drivers/xen/Makefile
> >@@ -1,9 +1,8 @@
> > ifeq ($(filter y, $(CONFIG_ARM) $(CONFIG_ARM64)),)
> >-obj-y	+= manage.o
> > obj-$(CONFIG_HOTPLUG_CPU)		+= cpu_hotplug.o
> > endif
> > obj-$(CONFIG_X86)			+= fallback.o
> >-obj-y	+= grant-table.o features.o events.o balloon.o time.o
> >+obj-y	+= grant-table.o features.o events.o balloon.o time.o manage.o
> > obj-y	+= xenbus/
> > 
> > nostackp := $(call cc-option, -fno-stack-protector)
> 
> The patch looks Ok but the description is off.  Power management is the term used for cpu freq,  C states and P states. While this patch touches none of that. 
> 

That's a very x86-centric view of the world, but it's true that manage.c
is about shutdown, restart and other operations that don't fit under
"power management".
It could benefit from a better description.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/