linux-kernel - Re: [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for DT usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130723123444.GW9858@sirena.org.uk>
Date:	Tue, 23 Jul 2013 13:34:44 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Jean-Francois Moine <moinejf@...e.fr>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Rob Herring <rob.herring@...xeda.com>,
	Russell King <rmk+kernel@....linux.org.uk>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	devicetree-discuss@...r.kernel.org
Subject: Re: [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for DT
 usage

On Tue, Jul 23, 2013 at 10:46:15AM +0200, Jean-Francois Moine wrote:

> +	np = pdev->dev.of_node;
> +	if (np) {
> +		struct of_phandle_args clkspec;
> +
> +		priv->burst = 128;			/* might be 32 or 128 */

The comment says this needs to be variable (depending on what?) but it's
hard coded.

> +		priv->clk = of_clk_get(np, 0);	/* internal clock */
> +		err = of_parse_phandle_with_args(np,
> +					"clocks", "#clock-cells", 1,
> +					&clkspec);

As others have pointed out if you need to change the clock get code
there's something wrong here, DT should be handled transparently by the
clock API.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)