linux-kernel - Re: [PATCH] kernel/irq/devres.c: move "kernel/irq/devres.c" to "drivers/base/devres

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Jul 2013 08:31:04 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Chen Gang <gang.chen@...anux.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kernel/irq/devres.c: move "kernel/irq/devres.c" to
 "drivers/base/devres_irq.c"

On Tue, Jul 23, 2013 at 03:36:04PM +0800, Chen Gang wrote:
> "kernel/irq/devres.c" is a driver extension tool for irq (with devres)
> which is independent on 'GENERIC_HARDIRQS', so it is not suitable to
> still be in "kernel/irq/" which depends on 'GENERIC_HARDIRQS'.
> 
> It is a basic tool for drivers, so can move it to "drivers/base/" to be
> independent on 'GENERIC_HARDIRQS'.
> 
> It is about irq features, so if can not find other more suitable place,
> can still let their declaration in "include/linux/interrupts.h".
> 
> The related error (with randconfig which disable 'GENERIC_HARDIRQS')
> 
>   drivers/built-in.o: In function `dw_dma_probe':
>   (.text+0x3747a): undefined reference to `devm_request_threaded_irq'

Don't fix problems when you are moving files around, that makes it
_very_ hard to review.

Remember, one thing per patch please.

> Signed-off-by: Chen Gang <gang.chen@...anux.com>
> ---
>  drivers/base/Makefile     |    2 +-
>  drivers/base/devres_irq.c |   94 +++++++++++++++++++++++++++++++++++++++++++++
>  kernel/irq/Makefile       |    2 +-
>  kernel/irq/devres.c       |   94 ---------------------------------------------
>  4 files changed, 96 insertions(+), 96 deletions(-)
>  create mode 100644 drivers/base/devres_irq.c
>  delete mode 100644 kernel/irq/devres.c

Please use git when renaming files so that the move is shown in the git
patch.  As it is, I would have to verify this by hand, and I don't want
to ever have to do that.

Also, I have no problem with the file being where it is.  This is for
irqs, which are handled by the interrupt maintainers, no need to put it
in the driver core, just because it happens to deal with "resources".
We arrange things for ease of maintainability, not always logically :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/