linux-kernel - Re: Linux 3.11-rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1374604305.12943.3.camel@leira.trondhjem.org>
Date:	Tue, 23 Jul 2013 18:31:46 +0000
From:	"Myklebust, Trond" <Trond.Myklebust@...app.com>
To:	"rydberg@...omail.se" <rydberg@...omail.se>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andre Heider <a.heider@...il.com>
Subject: Re: Linux 3.11-rc2

On Mon, 2013-07-22 at 21:17 -0400, Trond Myklebust wrote:
> On Tue, 2013-07-23 at 03:04 +0200, rydberg@...omail.se wrote:
> > Hi Trond, Linus,
> > 
> > On Sun, Jul 21, 2013 at 12:53:10PM -0700, Linus Torvalds wrote:
> > > So it's been another week, and -rc2 is out there.
> > 
> > This one happens to break nfs in a rather blunt-instrument fashion -
> > creating files on a nfs4 partition [1] no longer works. Bisection
> > yields this commit as the culprit:
> > 
> > commit b4a2cf76ab7c08628c62b2062dacefa496b59dfd
> > Author: Trond Myklebust <Trond.Myklebust@...app.com>
> > Date:   Wed Jul 17 16:43:16 2013 -0400
> > 
> >     NFSv4: Fix a regression against the FreeBSD server
> >     
> >     Technically, the Linux client is allowed by the NFSv4 spec to send
> >     3 word bitmaps as part of an OPEN request. However, this causes the
> >     current FreeBSD server to return NFS4ERR_ATTRNOTSUPP errors.
> >     
> >     Fix the regression by making the Linux client use a 2 word bitmap unless
> >     doing NFSv4.2 with labeled NFS.
> >     
> >     Signed-off-by: Trond Myklebust <Trond.Myklebust@...app.com>
> > 
> > Reverting the patch returns things to normal.
> 
> - Can you please provide me with a binary tcpdump or wireshark dump that
> demonstrates the problem?
> 
> - What server is this?

OK. With Andre's help, I think we've root caused the problem. Can you
please confirm that the attached patch also solves the issue for you?

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@...app.com
www.netapp.com

View attachment "0001-NFSv4-Fix-brainfart-in-attribute-length-calculation.patch" of type "text/x-patch" (1009 bytes)