linux-kernel - Re: [PATCH] drm: i915_gem_inactive_scan: insufficient nr_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130723192949.GA3786@thinkpad.lan>
Date:	Tue, 23 Jul 2013 23:29:49 +0400
From:	Artem Savkov <artem.savkov@...il.com>
To:	dchinner@...hat.com, glommer@...nvz.org
Cc:	daniel.vetter@...ll.ch, airlied@...ux.ie,
	intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: i915_gem_inactive_scan: insufficient nr_to_scan size

On Tue, Jul 23, 2013 at 11:18:06PM +0400, Artem Savkov wrote:
> nr_to_scan needs to be (unsigned) long, not int, otherwise we get negative
> values on 32bit systems during shrink resulting in lots of messages like one
> below.
> 
> [ 4078.989603] shrink_slab: i915_gem_inactive_scan+0x0/0xc0 negative objects to delete nr=-289580136
> 
> Introduced in "drivers: convert shrinkers to new count/scan API"
> (383e4f4a4cdeb2dd552e90811089bcb4d41eb32e in linux-next.git)

Sorry, looks like my analysis was wrong, I can still see the issue with this
patch.

-- 
Regards,
Artem
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/