linux-kernel - Re: [PATCH 2/2] regmap: irq: document mask/wake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130723193901.GR9858@sirena.org.uk>
Date:	Tue, 23 Jul 2013 20:39:01 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Philipp Zabel <p.zabel@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] regmap: irq: document mask/wake_invert, make them
 bool for consistency

On Mon, Jul 22, 2013 at 05:15:53PM +0200, Philipp Zabel wrote:

> -	unsigned int mask_invert;
> -	unsigned int wake_invert;
> +	bool mask_invert;
> +	bool wake_invert;

Actually we should probably make these bitfields and convert the other
booleans to bitfields, sadly the C bool type is equivalent to an int not
a bitfield so is more wasteful.

You shouldn't have mixed this in with the documentation fix...

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)