linux-kernel - Re: [PATCH] mvsas: fix unaligned-access kernel panic under heavy disk testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1374620157.2290.54.camel@dabdike>
Date:	Tue, 23 Jul 2013 15:55:57 -0700
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Chris Metcalf <cmetcalf@...era.com>
Cc:	Jianpeng Ma <majianpeng@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Xi Wang <xi.wang@...il.com>,
	Xiangliang Yu <yuxiangl@...vell.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mvsas: fix unaligned-access kernel panic under heavy
 disk testing

On Tue, 2013-07-23 at 18:40 -0400, Chris Metcalf wrote:
> On 7/23/2013 6:33 PM, James Bottomley wrote:
> > On Tue, 2013-07-23 at 17:17 -0400, Chris Metcalf wrote:
> >> On 7/23/2013 5:00 PM, James Bottomley wrote:
> >>> On Tue, 2013-07-23 at 16:50 -0400, Chris Metcalf wrote:
> >>>>> The slot->response value may not be aligned, so should be read
> >>>>> using the appropriate kernel "unaligned" accessor.
> >>> Hm, institutional memory re-presenting the wrong patch?  However, I am
> >>> reminded to push the right one in spite of no ack from marvell.
> >> You may be right; the original author of that patch is not me, but someone else here at Tilera.
> >>
> >> That said, the version I pushed is effectively the version we have in the tip of our tree, so if we've ended up carrying the wrong patch, that's bad!  Let me know what the right patch is that you have - thanks.
> > This is what I have.
> 
> Thanks, I've merged the optimization back into our tree :-)

Well it was originally a compile fix and a fast path optimisation.  I
notice the compile fix made it back.

James



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/