linux-kernel - Re: [PATCH v4] regulator: pfuze100: add pfuze100 regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130724094228.GY9858@sirena.org.uk>
Date:	Wed, 24 Jul 2013 10:42:28 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Steffen Trumtrar <s.trumtrar@...gutronix.de>
Cc:	Robin Gong <b38343@...escale.com>, shawn.guo@...aro.org,
	grant.likely@...aro.org, rob.herring@...xeda.com, rob@...dley.net,
	lgirdwood@...il.com, devicetree-discuss@...ts.ozlabs.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] regulator: pfuze100: add pfuze100 regulator driver

On Wed, Jul 24, 2013 at 10:30:41AM +0200, Steffen Trumtrar wrote:
> On Sun, Jul 21, 2013 at 05:17:27PM +0800, Robin Gong wrote:

> 
>  static struct regulator_ops pfuze100_fixed_regulator_ops = {
> 	.list_voltage = regulator_list_voltage_linear,
> +	.set_voltage_sel = regulator_set_voltage_sel_regmap,
>  };

This doesn't make much sense, you're adding a set voltage operation to a
fixed voltage regulator...

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)