linux-kernel - Re: Re: [PATCH] zcache: fix "zcache=" kernel parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130724114157.GB3976@dhcp22.suse.cz>
Date:	Wed, 24 Jul 2013 13:41:57 +0200
From:	Michal Hocko <mhocko@...e.cz>
To:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Cc:	gregkh@...uxfoundation.org,
	Piotr Sarna <p.sarna@...tner.samsung.com>,
	konrad.wilk@...cle.com, bob.liu@...cle.com,
	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: Re: [PATCH] zcache: fix "zcache=" kernel parameter

On Wed 24-07-13 12:32:32, Bartlomiej Zolnierkiewicz wrote:
> 
> Hi,
> 
> On Wednesday, July 24, 2013 12:04:41 PM Michal Hocko wrote:
> > On Wed 24-07-13 12:02:35, Michal Hocko wrote:
> > > I have posted a similar fix quite some time ago and I guess Greg should
> > > already have it.
> > 
> > For reference https://lkml.org/lkml/2013/6/26/410
> 
> There was a reply from Greg:
> 
> 	https://lkml.org/lkml/2013/6/26/410

I guess you meant https://lkml.org/lkml/2013/6/26/569

> and it seems that Greg's request has not been fullfilled.

Bob Liu has resent the patch (I cannot find the email in the archive).

> Anyway Piotr's patch seems to be more complete:
> - it also fixes case in which invalid "zcache=" option is given (returns
>   an error value 1 while with your patch the code still erronously retuns 0)
> - it prints information about compressor type being used when "zcache="
>   option is used (your patch skips it due to addition of "goto out_alloc")

I do not care which one will make it I just pointed out that there is
another patch dealing with the same and it is a question how far that
one went.
-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/