linux-kernel - Re: [PATCH 0/30] ACPI / hotplug / PCI: Major rework + Thunderbolt workarounds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6958813.eThhpoh5QO@vostro.rjw.lan>
Date:	Wed, 24 Jul 2013 14:58:38 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux PCI <linux-pci@...r.kernel.org>,
	Jiang Liu <liuj97@...il.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Subject: Re: [PATCH 0/30] ACPI / hotplug / PCI: Major rework + Thunderbolt workarounds

On Tuesday, July 23, 2013 07:20:53 PM Yinghai Lu wrote:
> On Tue, Jul 23, 2013 at 2:39 PM, Rafael J. Wysocki <rjw@...k.pl> wrote:

[...]

> [  102.631369] pci_host_bridge pci0000:00: freeing pci_host_bridge info

By the way this looks fishy:

> [  102.633091] ACPI: Device does not support D3cold
> [  102.633915] ACPI: Device does not support D3cold
> [  102.635221] ACPI: Device does not support D3cold
> [  102.636103] ACPI: Device does not support D3cold
> [  102.636902] ACPI: Device does not support D3cold
> [  102.637685] ACPI: Device does not support D3cold
> [  102.638467] ACPI: Device does not support D3cold
> [  102.639631] ACPI: Device does not support D3cold
> [  102.640472] ACPI: Device does not support D3cold
> [  102.641310] ACPI: Device does not support D3cold
> [  102.642105] ACPI: Device does not support D3cold
> [  102.642928] ACPI: Device does not support D3cold
> [  102.643725] ACPI: Device does not support D3cold
> [  102.644544] ACPI: Device does not support D3cold
> [  102.645344] ACPI: Device does not support D3cold
> [  102.646126] ACPI: Device does not support D3cold
> [  102.646902] ACPI: Device does not support D3cold
> [  102.647677] ACPI: Device does not support D3cold
> [  102.648485] ACPI: Device does not support D3cold
> [  102.649269] ACPI: Device does not support D3cold
> [  102.650065] ACPI: Device does not support D3cold
> [  102.650822] ACPI: Device does not support D3cold
> [  102.652483] ACPI: Device does not support D3cold
> [  102.654157] ACPI: Device does not support D3cold
> [  102.655803] ACPI: Device does not support D3cold
> [  102.657419] ACPI: Device does not support D3cold
> [  102.658528] ACPI: Device does not support D3cold
> [  102.659255] ACPI: Device does not support D3cold
> [  102.659973] ACPI: Device does not support D3cold
> [  102.661807] ACPI: Device does not support D3cold
> [  102.661925] ACPI: Device does not support D3cold
> [  102.662047] ACPI: Device does not support D3cold
> [  102.662148] ACPI: Device does not support D3cold
> [  102.662258] ACPI: Device does not support D3cold
> [  102.662374] ACPI: Device does not support D3cold
> [  102.662486] ACPI: Device does not support D3cold
> [  102.662597] ACPI: Device does not support D3cold
> [  102.662711] ACPI: Device does not support D3cold
> [  102.662814] ACPI: Device does not support D3cold
> [  102.662918] ACPI: Device does not support D3cold
> [  102.663019] ACPI: Device does not support D3cold

Can you please check if it goes away with the patch below applied?

> [  102.663039] ACPI: \_SB_.PCI0: No _EJ0 support for device


---
 drivers/acpi/device_pm.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: linux-pm/drivers/acpi/device_pm.c
===================================================================
--- linux-pm.orig/drivers/acpi/device_pm.c
+++ linux-pm/drivers/acpi/device_pm.c
@@ -159,7 +159,8 @@ int acpi_device_set_power(struct acpi_de
 	int result = 0;
 	bool cut_power = false;
 
-	if (!device || (state < ACPI_STATE_D0) || (state > ACPI_STATE_D3_COLD))
+	if (!device || !device->flags.power_manageable
+	    || (state < ACPI_STATE_D0) || (state > ACPI_STATE_D3_COLD))
 		return -EINVAL;
 
 	/* Make sure this is a valid target state */

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/