linux-kernel - Re: [PATCH V8 14/15] perf tools: add a function to calculate sample event size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130724130140.GB4203@krava.brq.redhat.com>
Date:	Wed, 24 Jul 2013 15:01:40 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Adrian Hunter <adrian.hunter@...el.com>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	linux-kernel@...r.kernel.org, David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Mike Galbraith <efault@....de>,
	Namhyung Kim <namhyung@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH V8 14/15] perf tools: add a function to calculate sample
 event size

On Thu, Jul 18, 2013 at 01:42:56PM +0300, Adrian Hunter wrote:

SNIP

> @@ -227,6 +227,8 @@ int perf_event__preprocess_sample(const union perf_event *self,
>  
>  const char *perf_event__name(unsigned int id);
>  
> +size_t perf_event__sample_event_size(const struct perf_sample *sample, u64 type,
> +				     u64 sample_regs_user);
>  int perf_event__synthesize_sample(union perf_event *event, u64 type,
>  				  u64 sample_regs_user,
>  				  const struct perf_sample *sample,
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index 047ab02..7a5ff06 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -1348,6 +1348,87 @@ int perf_evsel__parse_sample(struct perf_evsel *evsel, union perf_event *event,
>  	return 0;
>  }
>  
> +size_t perf_event__sample_event_size(const struct perf_sample *sample, u64 type,
> +				     u64 sample_regs_user)
> +{
> +	size_t sz, result = sizeof(struct sample_event);
> +
> +	if (type & PERF_SAMPLE_IDENTIFIER)
> +		result += sizeof(u64);
> +
> +	if (type & PERF_SAMPLE_IP)
> +		result += sizeof(u64);
> +
> +	if (type & PERF_SAMPLE_TID)
> +		result += sizeof(u64);
> +
> +	if (type & PERF_SAMPLE_TIME)
> +		result += sizeof(u64);
> +
> +	if (type & PERF_SAMPLE_ADDR)
> +		result += sizeof(u64);
> +
> +	if (type & PERF_SAMPLE_ID)
> +		result += sizeof(u64);
> +
> +	if (type & PERF_SAMPLE_STREAM_ID)
> +		result += sizeof(u64);
> +
> +	if (type & PERF_SAMPLE_CPU)
> +		result += sizeof(u64);
> +
> +	if (type & PERF_SAMPLE_PERIOD)
> +		result += sizeof(u64);
> +
> +	if (type & PERF_SAMPLE_READ) {
> +		fprintf(stderr, "PERF_SAMPLE_READ is unsupported for now\n");
> +		result += 8192; /* To be on the safe side */
> +	}

There' a patchset pending to be merged that implements
PERF_SAMPLE_READ. I wonder which one makes it in first..
looser will have to update this code ;-)

Acked-by: Jiri Olsa <jolsa@...hat.com>

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/